Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-70: Add eslint dependencies #160

Merged

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Aug 23, 2024

User story: DEV-70: Add eslint dependencies

Description

Adds required dependencies to run ESLint on custom JS.

This branch was tested with palantirnet/the-build#238
and passed tests on CircleCI: https://app.circleci.com/pipelines/github/palantirnet/the-build/589/workflows/fced6b6f-4a86-4e1a-8728-fd3610a1d741/jobs/600

Testing instructions

Open questions

  • Do we want to include all of these dependencies in the skeleton? They were the ones required while testing on a client site.

Remaining tasks

Delete this section if there are no remaining tasks.

  • Update the README

@becw becw merged commit 56db9a5 into develop Aug 26, 2024
1 check passed
@becw becw deleted the DEV-70-update-install-node-dependencies-task-in-the-build branch August 26, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants